-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perftest: support set flow_label list val in GRH with RR method #279
Conversation
extend #224 |
@HassanKhadour FYI |
@changchengx, can you please rebase? |
694ec3a
to
1c3dc86
Compare
@sshaulnv Done |
@sshaulnv @HassanKhadour ping |
@changchengx thanks for your contribution, the PR is under review |
Hi @changchengx ,
please fix it, and also update man page. Thanks |
1c3dc86
to
ad17144
Compare
@sshaulnv Thanks for your check. I've updated the commit according to your feedback and requirement. If you still hit some problem, please let me know the build environment: |
src/perftest_parameters.c
Outdated
} | ||
} | ||
|
||
if (user_param->flow_label) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in which scenario this will be true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sshaulnv Good catch, it seems that's dead code. I'll remove this if-condition and feedback later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sshaulnv This scenario is to deal with the case that user config the command option --flow_label=xxxx
for more than one time. This is rare case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the app checks for duplicate arguments on the 'parser' function, and if it will encounter more than one appearance of 'flow_label' it will produce:
Duplicated argument: flow_label
Parser function exited with Error
please remove the dead code.
beside this, everything looks great and we can merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sshaulnv I've removed the dead code and rebased this commit.
For different QPs, they may need to set different flow_label. Extend the flow_label option to support list val configuration and keep compatibility. Signed-off-by: Liu, Changcheng <changcheng.liu@aliyun.com>
ad17144
to
aec645e
Compare
Merged, thanks for your contribution! |
For different QP, it may need to set different flow_label. Extend the flow_label option to support list val configuration and keep compatibility.