sndk: rework shared capabilities with wdc plugin #2847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we split things off for the SanDisk plugin there were a few capability flags left off, which cause mismatches between the versions maintained for the WDC plugin. For now, this updates the flags to use shared values between the plugins, allowing for proper determination of support using the various run_wdc functions. This also adds one missing capabilities check for a command still supported in the new plugin. Reviewed-by: Jeffrey Lien <jeff.lien@sandisk.com> Signed-off-by: Brandon Paupore <brandon.paupore@wdc.com>
brandon-paupore-sndk
force-pushed
the
capabilities-rework
branch
from
0170ffa to
7f1d94e
Compare
Collaborator
|
Thanks! Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we split things off for the SanDisk plugin there were a few capability flags left off, which cause mismatches between the versions maintained for the WDC plugin. For now, this updates the flags to use shared values between the plugins, allowing for proper determination of support using the various run_wdc functions.
This also adds one missing capabilties check for a command still supported in the new plugin.
Reviewed-by: Jeffrey Lien jeff.lien@sandisk.com