plugins/mangoboost: Add plugin to support MangoBoost #2798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mango StorageBoost-NTI[1] is supported on MangoBoost-DPU(MB-DPU) and seamlessly integrates with existing systems. With this technology, we accelerate NVMe-oF by offloading full-stack of TCP to DPU hardware. This patch adds initial vendor specific extension of MangoBoost, which is id-ctrl command of MangoBoost NVMe virtual device. [1] https://www.mangoboost.io/products/hardware/mango-storageboost-tm-nti Signed-off-by: Jonghyeon Kim <jonghyeon.kim@mangoboost.io>
Collaborator
|
Looks good to me. The checkpatch errors are not really a concern. Would you mind also to provide man page for the new plugin? Thanks! |
Collaborator
|
github's rebase/merge button doesn't work right now. I'll try later again. |
Contributor
Author
|
Thanks for the review, and I'll add man page later. By the way, could you give me a tip for describing man page for nvme-cli? |
Collaborator
|
Have a look at the txt files in the Documentation folder and 9d24387 ("sed: add SED man pages") is pretty good example how to add docs for a new plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mango StorageBoost-NTI[1] is supported on MangoBoost-DPU(MB-DPU) and seamlessly integrates with existing systems. With this technology, we accelerate NVMe-oF by offloading full-stack of TCP to DPU hardware.
This patch adds initial vendor specific extension of MangoBoost, which is id-ctrl command of MangoBoost NVMe virtual device.
[1] https://www.mangoboost.io/products/hardware/mango-storageboost-tm-nti