wdc: plugin code cleanups #2782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-winkler-sndk
force-pushed
the
wdc_cleanup
branch
from
df4b2b7 to
86e2edd
Compare
Collaborator
|
Could you please rebase your changes (they are conflicting after the recent change) and also address the checkpatch errors? Thanks. |
Contributor
Author
|
I can rebase, though need a non-automated maintainer decision regarding the checkpatch warnings. Either we break strings or allow long lines. |
Collaborator
|
Ignore the checkpatch warnings, I thought checkpatch was pointing out other stuff. Sorry. |
Add wdc_is_zn350() wrapper to replace repeating open code condition (device_id == WDC_NVME_ZN350_DEV_ID || device_id == WDC_NVME_ZN350_DEV_ID_1) Signed-off-by: Tomas Winkler <tomas.winkler@sandisk.com>
1. Refactor function signatures to use `const char *` for char pointer arguments that are not intended to be modified. 2. Constify pointers to constant strings. This improves code clarity and prevents accidental modifications to read-only data. Signed-off-by: Tomas Winkler <tomas.winkler@sandisk.com>
Replace the internal implementation for finding specific UUIDs with the `nvme_uuid_find()` function provided by libnvme. This change simplifies the code and improves maintainability by leveraging a well-tested utility function from the library. While the internal implementation might have offered slightly better performance as we looped only once in few cases the clarity and reduced code duplication are preferred. Signed-off-by: Tomas Winkler <tomas.winkler@sandisk.com>
tomas-winkler-sndk
force-pushed
the
wdc_cleanup
branch
from
86e2edd to
bc9fb97
Compare
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor code improvements in wdc plugin.