Skip to content

Commit

Permalink
RDS: IB: fix ifnullfree.cocci warnings
Browse files Browse the repository at this point in the history
net/rds/ib.c:115:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Wu Fengguang authored and davem330 committed Feb 24, 2017
1 parent dfcb9f4 commit 77cc7ae
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions net/rds/ib.c
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,7 @@ static void rds_ib_dev_free(struct work_struct *work)
kfree(i_ipaddr);
}

if (rds_ibdev->vector_load)
kfree(rds_ibdev->vector_load);
kfree(rds_ibdev->vector_load);

kfree(rds_ibdev);
}
Expand Down

0 comments on commit 77cc7ae

Please sign in to comment.