sync testj1939 with latest kernel UAPI #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream version of J1939 stack has different UAPI. To make documented testj1939 examples work again we need at least boradcast flag. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
testj1939 need to use -B (broadcast) flag to be able to send or receive broadcast packages. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
josemic
reviewed
Nov 29, 2019
can-j1939-kickstart.md
Outdated
Comment on lines
59
to
60
| Binding a can-j1939 socket to a source address will register | ||
| allow you to send packets. |
There was a problem hiding this comment.
I do not understand the sentence. Please rephrase.
There was a problem hiding this comment.
This is not related to this patch. Usually a patch should be limited to one change or one sort of changes. If described issues is not related to this patch, then it should be reported or patched in different commit.
If patch is reviewed, review should be related to the patch. If patch has missing changes or changes are wrong, then review can prevent passing it to go upstream.
There was a problem hiding this comment.
Ok. Makes sense. Added bug #178 for that issue.
This example do not really demonstrate UAPI or testj1939 functionality. So, remove it. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.