Overhaul falky tests #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tolerance of the complete measurement-chain with a single sample and only little time for analog settling seems to be higher than 10 %. With 15 % tolerance the test succeeds.
Every now and than this test randomly fails, because the http-request to the `tacd` provides an old value. It seems that sometimes 0.2 s are not enough for the `tacd` to actually provide a new sample. This change increases the waiting time to 0.5 s, which seems to fix the issue.
It seems the default timeout of 30 s was too tight for tftp-ing 15 MB. Measurements show that the transfer takes between 26 and 32 s in about 15 samples. With with this change we increase the timeout a little bit, so that this test is hopefully less flaky.
It seems ruff has learned a new trick since the last PR in this repo. This fixes it.
jluebbe
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two tests
test_tacd_dut_power_off_floatingandtest_network_tftphave been proven to be flaky in CI.This PR aims at improving the tests.