Add support for Kannada language (https://kn.wikipedia.org) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivahr
commented
Jun 14, 2018
| @@ -131,7 +131,13 @@ public String getWikiMarkup(String s) { | |||
| return ""; | |||
| } | |||
|
|
|||
| return s.substring(textStart + 27, textEnd); | |||
| String s2 = s.substring(textStart + 27, textEnd); | |||
There was a problem hiding this comment.
The XML files exported from https://en.wikipedia.org/wiki/Special:Export have an additional attribute bytes in text element. Need to ignore this as well while reading wiki-markup.
shivahr
commented
Jun 14, 2018
| @@ -4,3 +4,4 @@ | |||
| .project | |||
| target/ | |||
| *~ | |||
| .DS_Store | |||
There was a problem hiding this comment.
.DS_Store file on Mac needs to be ignored.
|
@shivahr Thanks for the contribution. Do you want me to cut another release and push to Maven central? |
|
Thanks for merging. And yes, pushing a new version to Maven central would certainly help. |
|
Done! Thanks once again: |
|
OK cool. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @lintool for this awesome code. Found exactly what I was looking for.