-
Notifications
You must be signed in to change notification settings - Fork 105
Support LKE-E phase 2: Bring Your Own VPC, Dual Stack Cluster, Audit Log Enabling #2079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for LKE Enterprise phase 2 features including Bring Your Own VPC, dual stack clusters, and audit log enabling. This update extends the LKE cluster resource and data sources with new VPC networking capabilities and enhanced control plane configuration options.
- Added VPC and subnet ID fields for BYO VPC functionality
- Implemented dual stack networking support with stack type configuration
- Added audit logs enablement for cluster control plane
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
linode/lkeclusters/framework_models.go | Added new fields for subnet ID, VPC ID, stack type, and audit logs to cluster models |
linode/lkeclusters/framework_datasource_schema.go | Extended datasource schema with new VPC and audit log attributes |
linode/lke/tmpl/template.go | Added audit logs template data field |
linode/lke/tmpl/enterprise.gotf | Updated enterprise template to include VPC resource and configuration |
linode/lke/schema_resource.go | Added schema definitions for new VPC and audit log fields with validation |
linode/lke/resource.go | Implemented creation and reading logic for new VPC and audit log fields |
linode/lke/framework_resource_test.go | Updated enterprise test with hardcoded region and version for BYO VPC testing |
linode/lke/framework_models.go | Added new fields to framework data models for VPC and audit log support |
linode/lke/framework_datasource_schema.go | Extended framework datasource schema with new attributes |
linode/lke/cluster.go | Added flattening and expanding logic for audit logs in control plane |
go.mod | Added temporary linodego dependency replacement |
docs/resources/lke_cluster.md | Updated documentation with new fields and enterprise cluster example |
docs/data-sources/lke_clusters.md | Added documentation for new VPC and audit log attributes |
docs/data-sources/lke_cluster.md | Updated datasource documentation with new field descriptions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great other than the small fix above. Great work!
📝 Description
Support a couple of new fields and options for LKE enterprise: Bring your own VPC/Subnet; Support dual stack cluster; Allow to enable audit log in cluster control plane.
✔️ How to Test
There is a list of tags you will need with your account for testing. Please refer to the Jira epic for details.
Integration test:
Manual test: