upcoming: [UIE-9741] - Implement Add Lock Modal. #13339
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
38
to
44
| /** | ||
| * Validation error with optional field name for API error responses | ||
| */ | ||
| interface ValidationError { | ||
| field?: string; | ||
| reason: string; | ||
| } |
Member
There was a problem hiding this comment.
Could we just reuse the existing APIError type from @linode/api-v4?
tanushree-akamai
requested review from
grevanak-akamai,
harsh-akamai and
pmakode-akamai
…/unlocked irrespective of LKE association.
|
|
||
| expect(getByText('Prevent deletion')).toBeVisible(); | ||
| expect( | ||
| getByText('Protects this Linode from being deleted or rebuilt.') |
Contributor
There was a problem hiding this comment.
This text needs to be updated to fix this failing test case
tanushree-akamai
force-pushed
the
feature/UIE-9741-resprot2-add-lock-modal
branch
from
df1420d to
422b6b3
Compare
| <FormControlLabel | ||
| control={<Radio />} | ||
| label={ | ||
| <LockOptionLabel |
Contributor
There was a problem hiding this comment.
As per figma(not sure whether this is the latest one), text for options should be right aligned with radio button.
Contributor
There was a problem hiding this comment.
When Add lock dialog is opened from linode details page, onClose is not working. Both Cancel and submit actions are not closing the dialog
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #5 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR implements the Add Lock modal accessible from the Linode action menu.
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
Screen.Recording.2026-01-28.at.11.15.07.PM.mov
How to test 🧪
Reproduction steps
[ "create_lock", "delete_lock" ]
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅