Skip to content

change: [DPS-36289] - Logs, mark Log Path field as optional #13338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kagora-akamai wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

change: [DPS-36289] - Logs, mark Log Path field as optional #13338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-13338-changed-1769606596075.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Changed
---

Logs - (optional) text added to Log Path Prefix field label ([#13338](https://github.com/linode/manager/pull/13338))
12 changes: 9 additions & 3 deletions ...ges/manager/src/features/Delivery/Destinations/DestinationForm/DestinationCreate.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@
await userEvent.type(accessKeyIDInput, 'Test');
const secretAccessKeyInput = screen.getByLabelText('Secret Access Key');
await userEvent.type(secretAccessKeyInput, 'Test');
const logPathPrefixInput = screen.getByLabelText('Log Path Prefix');
const logPathPrefixInput = screen.getByLabelText(
'Log Path Prefix (optional)'

Check warning on line 72 in packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationCreate.test.tsx

View workflow job for this annotation

GitHub Actions / ESLint Review (manager) 

[eslint] reported by reviewdog 🐶
Define a constant instead of duplicating this literal 3 times.

Raw Output:
{"ruleId":"sonarjs/no-duplicate-string","severity":1,"message":"Define a constant instead of duplicating this literal 3 times.","line":72,"column":11,"nodeType":"Literal","endLine":72,"endColumn":39}
);
await userEvent.type(logPathPrefixInput, 'Test');

expect(destinationNameInput).toHaveValue('Test');
Expand Down Expand Up @@ -101,7 +103,9 @@
expect(samplePath).toBeInTheDocument();
});
// Type the test value inside the input
const logPathPrefixInput = screen.getByLabelText('Log Path Prefix');
const logPathPrefixInput = screen.getByLabelText(
'Log Path Prefix (optional)'
);

await userEvent.type(logPathPrefixInput, 'test');
// sample path should be created based on *log path* value
Expand Down Expand Up @@ -218,7 +222,9 @@
await userEvent.type(accessKeyIDInput, 'Test');
const secretAccessKeyInput = screen.getByLabelText('Secret Access Key');
await userEvent.type(secretAccessKeyInput, 'Test');
const logPathPrefixInput = screen.getByLabelText('Log Path Prefix');
const logPathPrefixInput = screen.getByLabelText(
'Log Path Prefix (optional)'
);
await userEvent.type(logPathPrefixInput, 'Test');
};

Expand Down
2 changes: 1 addition & 1 deletion packages/manager/src/features/Delivery/Destinations/DestinationForm/DestinationEdit.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ describe('DestinationEdit', () => {
assertInputHasValue('Bucket', 'destinations-bucket-name');
assertInputHasValue('Access Key ID', 'Access Id');
assertInputHasValue('Secret Access Key', '');
assertInputHasValue('Log Path Prefix', 'file');
assertInputHasValue('Log Path Prefix (optional)', 'file');
});

describe('given Test Connection and Edit Destination buttons', () => {
Expand Down
1 change: 1 addition & 0 deletions packages/manager/src/features/Delivery/Shared/DestinationAkamaiObjectStorageDetailsForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ export const DestinationAkamaiObjectStorageDetailsForm = ({
label="Log Path Prefix"
onBlur={field.onBlur}
onChange={(value) => field.onChange(value)}
optional
placeholder="Prefix for log storage path"
sx={{ maxWidth: 416 }}
value={field.value}
Expand Down
4 changes: 3 additions & 1 deletion ...ges/manager/src/features/Delivery/Streams/StreamForm/Delivery/StreamFormDelivery.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,9 @@ describe('StreamFormDelivery', () => {
);

// Type the test value inside the input
const logPathPrefixInput = screen.getByLabelText('Log Path Prefix');
const logPathPrefixInput = screen.getByLabelText(
'Log Path Prefix (optional)'
);
await userEvent.type(logPathPrefixInput, 'Test');

expect(logPathPrefixInput.getAttribute('value')).toEqual('Test');
Expand Down
4 changes: 3 additions & 1 deletion packages/manager/src/features/Delivery/Streams/StreamForm/StreamCreate.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ describe('StreamCreate', () => {
await userEvent.type(accessKeyIDInput, 'Test');
const secretAccessKeyInput = screen.getByLabelText('Secret Access Key');
await userEvent.type(secretAccessKeyInput, 'Test');
const logPathPrefixInput = screen.getByLabelText('Log Path Prefix');
const logPathPrefixInput = screen.getByLabelText(
'Log Path Prefix (optional)'
);
await userEvent.type(logPathPrefixInput, 'Test');
};

Expand Down
4 changes: 3 additions & 1 deletion packages/manager/src/features/Delivery/Streams/StreamForm/StreamEdit.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,9 @@ describe('StreamEdit', () => {
await userEvent.type(accessKeyIDInput, 'Test');
const secretAccessKeyInput = screen.getByLabelText('Secret Access Key');
await userEvent.type(secretAccessKeyInput, 'Test');
const logPathPrefixInput = screen.getByLabelText('Log Path Prefix');
const logPathPrefixInput = screen.getByLabelText(
'Log Path Prefix (optional)'
);
await userEvent.type(logPathPrefixInput, 'Test');
};

Expand Down