Skip to content

Conversation

@mpolotsk-akamai
Copy link
Contributor

Description 📝

This PR fixes issue with user type in /iam/users. The selected user type is not applied after reloading the page.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Initialized user type filter from URL parameter to ensure selection is preserved after page reload.

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

How to test 🧪

Prerequisites

(How to setup test environment)

  • use Child Account
  • IAM Delegation (Parent/Child) feature flag should be enabled

Verification steps

(How to verify changes)

  • Go to /iam/users as child user.
  • Select user type in user type filter.
  • Notice URL param is added (example ?users=delegate).
  • Refresh the page.
  • Verify that user type filter is applied.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mpolotsk-akamai mpolotsk-akamai marked this pull request as ready for review January 27, 2026 15:22
@mpolotsk-akamai mpolotsk-akamai requested a review from a team as a code owner January 27, 2026 15:22
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, ty!

filterableOptions.find((option) => option.value === usersParam) ||
ALL_USERS_OPTION
);
}, [usersParam]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can include the dependency in the array as suggested by the liniting warning. less noise in the codebase :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Included, thanks!

Copy link
Contributor

@aaleksee-akamai aaleksee-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jan 28, 2026
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing864 Passing11 Skipped44m 15s

Details

Failing Tests
SpecTest
create-linode-with-add-ons.spec.tsCloud Manager Cypress Tests→Create Linode with Add-ons » can select private IP during Linode Create flow

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/create-linode-with-add-ons.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IAM Delegation Implementing the new Parent/Child delegation UI IAM (Identity & Access Management)

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

4 participants