Skip to content

Conversation

@mduda-akamai
Copy link
Contributor

@mduda-akamai mduda-akamai commented Jan 27, 2026

Description 📝

Add the Additional Options section to the Custom HTTPS destination form, adjust mocks and factories to enable creating a Custom HTTPS destination

Changes 🔄

  • Add the Addition Options section to the Destination form in the Create Destination and Create Stream forms with subsections:
    • Client Certificate
    • HTTPS Headers
    • Add Custom Header
  • Modify factories and mocks to add the possibility to create Custom HTTPS destinations
  • Remove unnecessary placeholders
  • Adjust e2e and unit tests

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • No customers / Not applicable

Target release date 🗓️

March 2026

Preview 📷

Before After
Before destination creation After destination creation
Before stream creation After stream creation

How to test 🧪

Prerequisites

  • Set aclpLogs.customHttpsEnabled and aclpLogs.enabled flags to true

Verification steps

  • Check in logs/delivery/streams/create if Custom HTTPS type has the Additional Options section and check all present fields
  • Check in logs/delivery/destinations/create if Custom HTTPS type has the Additional Options section and check all present fields
  • Check if the Test Connection and Create Destination/Stream buttons for the Custom HTTPS destination work
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
➕ Adding a changeset
🧪 Providing/improving test coverage
🚩 Using a feature flag to protect the release
📱 Providing mobile support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mduda-akamai mduda-akamai requested review from a team as code owners January 27, 2026 15:08
@mduda-akamai mduda-akamai requested review from jdamore-linode and removed request for a team January 27, 2026 15:08
@mduda-akamai mduda-akamai force-pushed the feature/DPS-35925-custom-https-form-additional-options-section branch from 95407d2 to da46a0e Compare January 27, 2026 15:15
@mduda-akamai mduda-akamai self-assigned this Jan 27, 2026
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing863 Passing11 Skipped43m 4s

Details

Failing Tests
SpecTest
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page
create-linode-with-add-ons.spec.tsCloud Manager Cypress Tests→Create Linode with Add-ons » can select private IP during Linode Create flow

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/linodes/create-linode-with-add-ons.spec.ts"

Copy link
Contributor

@kagora-akamai kagora-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

3 participants