-
Notifications
You must be signed in to change notification settings - Fork 392
feat: [UIE-10074, UIE-10076, UIE-10075] - IAM: bugs resetting to prev page #13330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
| // Check if the change decreased the total roles by exactly one. | ||
| // This occurs when switching to a role the user already had, | ||
| // causing the two roles to merge into a single entry. | ||
| const decreasedByOne = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we need it:
user has linode_admin and linode_viewer. Change role action can result in 2 different outcomes:
- change role to a new one
ex: changing fromlinode_viewertolinode_contributor
The total number of roles does not change (one role is replaced by another) - change role to an existing one
ex: changing fromlinode_viewertolinode_admin(when the user already haslinode_admin)
The total number of roles decreases by one, because two roles are merged into a single role entry
So we should reset to the previous page only when the total number of roles decreases
Cloud Manager UI test results🔺 1 failing test on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/create-linode-with-add-ons.spec.ts" |
|||||||||||||||||
|
@aaleksee-akamai i came up with what I think is a much cleaner approach: #13346 please let me know what you think. If we go with it we should consider updating |
Description 📝
This PR fixes couple of bugs related to resetting page in Assigned Roles/Entities table when user Remove/Unassign/Change role/Assignment
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
Screen.Recording.2026-01-28.at.10.12.03.AM.mov
Screen.Recording.2026-01-28.at.10.13.25.AM.mov
Screen.Recording.2026-01-28.at.10.22.19.AM.mov
Screen.Recording.2026-01-28.at.10.23.27.AM.mov
Screen.Recording.2026-01-28.at.10.24.48.AM.mov
Screen.Recording.2026-01-28.at.10.25.44.AM.mov
Screen.Recording.2026-01-28.at.10.40.11.AM.mov
Screen.Recording.2026-01-28.at.10.41.03.AM.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
UIE-10074
UIE-10075 - 1st issue
linode_adminrole is the last one on the 1st page andlinode_contributeris the 1st role on the 2nd pagelinode_contributertolinode_viewerUIE-10075 - 2nd issue
UIE-10076
Verification steps
(How to verify changes)
UIE-10074
UIE-10075
UIE-10076
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅