Skip to content

Conversation

@dchyrva-akamai
Copy link
Contributor

Description 📝

ACLP Service availability check added to the bucket metrics tab

How to test 🧪

  • Run pnpm dev
  • Navigate to /object-storage/buckets/<region>/<bucket>
  • Observe "Metrics Tab" button, it should be hidden when
    ACLP service is unavailable.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing864 Passing11 Skipped37m 31s

Details

Failing Tests
SpecTest
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

No a blocker but there is a brief "flash" of the Metrics tab showing, then it quickly goes away once the https://api.linode.com/v4/monitor/services/objectstorage fetch fails.

There are a few ways we could address that

  • change condition to also checking for the loading state
  • Rather than checking for an error, we could check to see if data becomes defined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Object Storage deals with Object Storage

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

4 participants