Skip to content

Conversation

@pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Jan 19, 2026

Description 📝

Refactor Marketplace v2 and Add Marketplace filters to the Products landing page.

Note

There have been some changes in the approach for Marketplace V2 from the Product. The APIs will no longer be available, and we will fully rely on client-side filtering and client-side management of Marketplace V2 products

Changes 🔄

  • Refactor Marketplace to not use any products, partners, types queries and clean up unnecessary code and logic
  • Add Marketplace filters to the Products landing page
  • Display an empty state if there are no products to display (either no products exist, or filters return no results)

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

N/A

Preview 📷

Filters:
Screenshot 2026-01-19 at 6 02 51 PM

Empty States:

  • When filters are applied:
    Screenshot 2026-01-20 at 6 10 52 PM

  • When no categories with products are available:
    Screenshot 2026-01-20 at 6 14 49 PM

How to test 🧪

Prerequisites

  • Enable MSW and MarketplaceV2 feature flag

Verification steps

  • Verify filtering using the search input for name, description, partners, and type
  • Verify filtering using dropdowns, search input, or a combination of both
  • Verify empty states:
    • When no products are available
    • When no results are returned after applying filters
    • Ensure the Reset Filters link/button works as expected from the empty state
  • Ensure there are no regressions
  • Ensure all checks pass
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@pmakode-akamai pmakode-akamai marked this pull request as ready for review January 19, 2026 13:08
@pmakode-akamai pmakode-akamai requested a review from a team as a code owner January 19, 2026 13:08
if (value && value !== textFieldValue) {
if (value !== textFieldValue) {
setTextFieldValue(value);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change ensures that the internal state correctly synchronizes with the value prop even when it is an empty string. Previously, the condition value && value !== textFieldValue prevented updates when value was "", so clearing the search field would not update the internal state or reflect in the UI. By changing the condition to value !== textFieldValue, the field now correctly resets, and the UI and internal state stay in sync when the search field is cleared.

We can test this by resetting the filters from the Filters empty state to ensure the field clears/resets correctly in the UI.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component is used throughout the app, have you tested other areas to confirm there have been no regressions/behavior changes? I spot checked a few places and didn't notice any.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did check and didn't notice any issues either

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verification steps ✅
Code review ✅

if (value && value !== textFieldValue) {
if (value !== textFieldValue) {
setTextFieldValue(value);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component is used throughout the app, have you tested other areas to confirm there have been no regressions/behavior changes? I spot checked a few places and didn't notice any.

@tvijay-akamai
Copy link
Contributor

As discussed, When filtering also let's make use of waypoint and handle empty state by making api call in batches if no products are found.

@pmakode-akamai
Copy link
Contributor Author

pmakode-akamai commented Jan 22, 2026

As discussed, When filtering also let's make use of waypoint and handle empty state by making api call in batches if no products are found.

This logic is already handled in the current implementation of MarketplaceLanding.tsx‎ at L199-L222

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily added these logos from src/assets. These duplicate logos here need to be replaced with the actual product logos (for both light and dark modes) and placed in the appropriate directory

name: 'Data Service',
},
categories: ['CDN Affiliated'],
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are dummy product examples. The products added here (in the list) need to be replaced with the actual products.

data: categories,
error,
isLoading,
} = useAllMarketplaceCategoriesQuery({}, {}, isMarketplaceV2FeatureEnabled);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this query and the related ones (for more context, see the PR description note). We'll create a separate ticket to clean up all the queries and mocks added in queries and other packages cc @harsh-akamai

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #15 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing864 Passing11 Skipped38m 10s

Details

Failing Tests
SpecTest
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

5 participants