Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: [M3-8533, M3-8761] - Fix firewall rules table and Replace react-beautiful-dnd with dnd-kit lib #11127

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
+267 −290
Open

change: [M3-8533, M3-8761] - Fix firewall rules table and Replace react-beautiful-dnd with dnd-kit lib #11127

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
89a968e
Fix firewall rules table
pmakode-akamai Oct 15, 2024
e676f0a
Update the comment
pmakode-akamai Oct 16, 2024
f582ff1
Added changeset: Broken firewall rules table
pmakode-akamai Oct 16, 2024
ae7fb54
Keeping PolicyRow to 2 grids for sm breakpoint
pmakode-akamai Oct 16, 2024
bb888b3
Add padding to headers and cells
pmakode-akamai Oct 17, 2024
40a2546
Add line height to StyledHeaderItemBox
pmakode-akamai Oct 17, 2024
ec6e957
Update some styles
pmakode-akamai Oct 17, 2024
6419b0e
Update styles
pmakode-akamai Oct 17, 2024
ae072cf
Fix broken firewall rules table and replace react-beautiful-dnd with …
pmakode-akamai Oct 18, 2024
1933199
Set cursor style to 'grab' or 'grabbing' based on drag state
pmakode-akamai Oct 18, 2024
10a4ebf
isDragging state var pos fix
pmakode-akamai Oct 18, 2024
04fd4fe
Add TouchSensor and collisionDetection
pmakode-akamai Oct 19, 2024
5da7817
Add width to table cells for improved layout
pmakode-akamai Oct 21, 2024
691796f
Some cleanup...
pmakode-akamai Oct 21, 2024
c34c57e
Update width
pmakode-akamai Oct 21, 2024
2f0501d
Fix colors for pending deletion row and clean up styling for rule btn
pmakode-akamai Oct 21, 2024
4b74481
Added changeset: Broken firewall rules table
pmakode-akamai Oct 21, 2024
e425c84
Added changeset: Replace `react-beautiful-dnd` with `dnd-kit` library
pmakode-akamai Oct 21, 2024
36b71cc
Remove react-beautiful-dnd from the codebase
pmakode-akamai Oct 22, 2024
ceb209a
Remove react-beautiful-dnd from the codebase
pmakode-akamai Oct 22, 2024
82da654
Remove initial pos focus on drag end and enable rows to drag over others
pmakode-akamai Oct 22, 2024
35ce198
Refactoring...
pmakode-akamai Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update width
  • Loading branch information
@pmakode-akamai
pmakode-akamai committed Oct 22, 2024
commit c34c57e6c53d252f17078bb5d287239e6c04a8ed
6 changes: 3 additions & 3 deletions packages/manager/src/features/Firewalls/FirewallDetail/Rules/FirewallRuleTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export const FirewallRuleTable = (props: FirewallRuleTableProps) => {
<Table>
<TableHead aria-label={`${category} Rules List Headers`}>
<TableRow>
<TableCell sx={{ width: smDown ? '50%' : '28%' }}>
<TableCell sx={{ width: smDown ? '50%' : '26%' }}>
Label
</TableCell>
<Hidden lgDown>
Expand Down Expand Up @@ -411,12 +411,12 @@ export const PolicyRow = React.memo((props: PolicyRowProps) => {
display: 'grid',
fontSize: '.875rem',
gridTemplateAreas: `'one two three four five six'`,
gridTemplateColumns: '28% 10% 15% 15% 10% 120px',
gridTemplateColumns: '26% 10% 15% 15% 10% 120px',
height: '40px',
marginTop: '10px',
[theme.breakpoints.down('lg')]: {
gridTemplateAreas: `'one two three four five'`,
gridTemplateColumns: '28% 15% 15% 10% 120px',
gridTemplateColumns: '26% 15% 15% 10% 120px',
},
[theme.breakpoints.down('sm')]: {
gridTemplateAreas: `'one two'`,
Expand Down