project: Linode Disk Encryption #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Linode DiskEncryption fields DiskEncryption can be set at Linode creation time, however it cannot be altered after instance creation. * Add DiskEncryption fields to LKENodePools LKENodePool instances have disc encryption is not configurable and is enabled by default. Existing LKENodePools will create instances that DO NOT have disk encryption enabled. As such there is no option to set DiskEncryption on LKENodePools at creation time but the status of DiskEncryption is returned from the API when viewing LKENodePools. * DiskEncryption integration tests * Update k8s to supported version * Add check for LKE nodepool disk encryption New node pools have disk encryption enabled by default * Target DCs with Disk Encryption * Update LKE tests & fixtures * Add LKEClusterID to instance struct Add test to validate the field * Add DiskEncryption to disks, linode create and rebuild opts Add new tests for listing disks with encryption and rebuilding disks with encryption. New tests are required as Disk Encryption is not live yet * Update alpine image to latest Image is available in dev * Check Linode LKE clusterID field This does not yet work in dev so test addition is commented out * Fix ClusterNodesReady desc Bad pasta Co-authored-by: Lena Garber <114949949+lgarber-akamai@users.noreply.github.com> --------- Co-authored-by: Lena Garber <lgarber@akamai.com> Co-authored-by: Lena Garber <114949949+lgarber-akamai@users.noreply.github.com>
lgarber-akamai
requested review from
jriddle-linode and
ezilber-akamai
and removed request for
a team
lgarber-akamai
added
the
do-not-merge
ezilber-akamai
approved these changes
Jul 8, 2024
jriddle-linode
approved these changes
Jul 9, 2024
lgarber-akamai
removed
the
do-not-merge
lgarber-akamai
commented
Jul 10, 2024
| @@ -21,3 +21,4 @@ | |||
| vendor/**/ | |||
| .env | |||
| coverage.txt | |||
| go.work.sum | |||
There was a problem hiding this comment.
Matches this change from the Images Gen. 2 project branch: https://github.com/linode/linodego/blob/proj/images-gen2/.gitignore#L25
lgarber-akamai
added
the
do-not-merge
lgarber-akamai
removed
the
do-not-merge
jriddle-linode
approved these changes
Jul 23, 2024
ezilber-akamai
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request merges the Linode Disk Encryption project into the main branch.