Migrate LKE and MySQL Client Functions to Utilize Request Helpers #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezilber-akamai
requested review from
lgarber-akamai and
zliang-akamai
and removed request for
a team
ezilber-akamai
force-pushed
the
TPT-2875-lke_cluster_pools-mysql
branch
from
b335d2d
to
22ab268
Compare
| updatedK8sVersion := "1.23" | ||
| isHA := true | ||
| updatedK8sVersion := "1.30" | ||
| isHA := false |
There was a problem hiding this comment.
Note for other reviewers:
As of now HA cannot be specified in the same PUT request as a K8s version upgrade, which caused issues here because we can't guarantee there will be multiple LKE versions available at any given time.
Comment on lines
197
to
+201
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return r.Result().(*LKECluster), nil | ||
|
|
||
| return response, nil |
There was a problem hiding this comment.
optional: This logic can be simplified down to return response, err 👍
lgarber-akamai
approved these changes
Jul 5, 2024
|
This seems much more than lke_cluster_pools and mysql, maybe considering update the title and description to something like: |
ezilber-akamai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Migrate LKE and MySQL Client Functions to Utilize Request Helpers