Add support for VPCSubnet.databases field#607
Merged
lgarber-akamai merged 3 commits intolinode:proj/dbaas-vpcfrom Oct 6, 2025
Merged
Add support for VPCSubnet.databases field#607lgarber-akamai merged 3 commits intolinode:proj/dbaas-vpcfrom
lgarber-akamai merged 3 commits intolinode:proj/dbaas-vpcfrom
Conversation
zliang-akamai
approved these changes
Oct 6, 2025
Member
zliang-akamai
left a comment
There was a problem hiding this comment.
Looks good and works well!
yec-akamai
approved these changes
Oct 6, 2025
Contributor
yec-akamai
left a comment
There was a problem hiding this comment.
Works well on my end!
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the databases field in VPC subnets to handle Managed Databases attached to VPC subnets. The implementation includes a new VPCSubnetDatabase class and corresponding property mapping.
- Adds
VPCSubnetDatabasedata class to represent database information within VPC subnets - Updates
VPCSubnetclass to include thedatabasesproperty - Adds comprehensive test coverage including fixtures and validation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| linode_api4/objects/vpc.py | Adds VPCSubnetDatabase class and databases property to VPCSubnet |
| test/unit/objects/vpc_test.py | Adds test validation for databases field functionality |
| test/fixtures/vpcs_123456_subnets_789.json | Adds test fixture data for single subnet with database |
| test/fixtures/vpcs_123456_subnets.json | Adds test fixture data for subnet list with database |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
lgarber-akamai
added a commit
that referenced
this pull request
Oct 7, 2025
* Added support for VPC DBaaS Integration (#560) * Implemented support for VPC DBaaS Integration * Added unit tests * Add support for VPCSubnet.databases field (#607) * Add support for VPCSubnet.databases field * ipv6_range -> ipv6_ranges * ipv6_range -> ipv6_ranges (list) --------- Co-authored-by: Erik Zilber <ezilber@akamai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request adds support for the
databasesfield returned for VPC subnets with attached Managed Databases.✔️ How to Test
The following test steps assume you have pulled down this PR locally and run
make install.Unit Testing
Manual Testing