Enable include_none_values in FirewallSettingsDefaultFirewallIDs#558
Merged
zliang-akamai merged 2 commits intolinode:proj/enhanced-interfacesfrom May 28, 2025
Conversation
zliang-akamai
requested review from
jriddle-linode and
lgarber-akamai
and removed request for
a team
…-include_none_values
lgarber-akamai
approved these changes
May 28, 2025
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
ezilber-akamai
approved these changes
May 28, 2025
zliang-akamai
merged commit 06f8a5f
into
linode:proj/enhanced-interfaces
12 checks passed
zliang-akamai
added a commit
that referenced
this pull request
Sep 22, 2025
* Enhanced Interfaces: Add support for Firewall templates (#529) * Add support for Firewall Templates * oops * Add LA notices * Enhanced Interfaces: Add account-related fields (#525) * Enhanced Interfaces: Add account-related fields * Add setting enum * Add LA notice * Drop residual print * Enhanced Interfaces: Implement endpoints & fields related to VPCs and non-interface networking (#526) * Implement endpoints & fields related to VPCs and non-interface networking * Add LA notices * Enhanced Interfaces: Add support for Linode-related endpoints and fields (#533) * Add support for Linode-related endpoints and fields * oops * tiny fixes * fix docsa * Add docs examples * Docs fixes * oops * Remove irrelevant test * Add LA notices * Fill in API documentation URLs * Add return types * Enable `include_none_values` in FirewallSettingsDefaultFirewallIDs (#558) * Linode Interfaces: Allow specifying ExplicitNullValue for LinodeInterfaceOptions firewall ID (#565) * Add ExplicitNullValue support * Fix failing integration tests * Add unit tests * Add docs disclaimer * Fix * Update test/fixtures/linode_instances.json Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/unit/objects/linode_test.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/integration/conftest.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update linode_api4/objects/linode.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * More fixes * lint * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Remove unnecessary local imports * Fix IPv6 addresses * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/unit/objects/networking_test.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/unit/objects/linode_test.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Lena Garber <114949949+lgarber-akamai@users.noreply.github.com> Co-authored-by: Lena Garber <lgarber@akamai.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
lgarber-akamai
added a commit
that referenced
this pull request
Oct 7, 2025
* Enhanced Interfaces: Add support for Firewall templates (#529) * Add support for Firewall Templates * oops * Add LA notices * Enhanced Interfaces: Add account-related fields (#525) * Enhanced Interfaces: Add account-related fields * Add setting enum * Add LA notice * Drop residual print * Enhanced Interfaces: Implement endpoints & fields related to VPCs and non-interface networking (#526) * Implement endpoints & fields related to VPCs and non-interface networking * Add LA notices * Implement support for VPC Dual Stack (#524) * Enhanced Interfaces: Add support for Linode-related endpoints and fields (#533) * Add support for Linode-related endpoints and fields * oops * tiny fixes * fix docsa * Add docs examples * Docs fixes * oops * Remove irrelevant test * Add LA notices * Fill in API documentation URLs * Add return types * Enable `include_none_values` in FirewallSettingsDefaultFirewallIDs (#558) * VPC Dual Stack: Support changes related to Linode Interfaces (#559) * Implementation; needs tests * Add integration tests * vpctest * removeprint * test * Fix conflicts * Fix missed conflict --------- Co-authored-by: Zhiwei Liang <zliang@akamai.com> Co-authored-by: Zhiwei Liang <121905282+zliang-akamai@users.noreply.github.com> Co-authored-by: vshanthe <vshanthe@akamai.com> Co-authored-by: Vinay <143587840+vshanthe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This is to enable
include_none_valuesinFirewallSettingsDefaultFirewallIDsclass to shownullin thedict.Needed by linode/ansible_linode#681