fix: Add / prefix to path in mysql_config_options(...) and postgresql_config_options(...) API calls#542
Merged
lgarber-akamai merged 1 commit intolinode:proj/configurable-db-paramsfrom May 12, 2025
Conversation
lgarber-akamai
requested review from
ezilber-akamai,
jriddle-linode and
yec-akamai
and removed request for
a team and
jriddle-linode
lgarber-akamai
changed the title
ezilber-akamai
approved these changes
May 7, 2025
Contributor
ezilber-akamai
left a comment
ezilber-akamai
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
ykim-akamai
approved these changes
May 9, 2025
Contributor
ykim-akamai
left a comment
ykim-akamai
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix
lgarber-akamai
merged commit 2a90e6f
into
linode:proj/configurable-db-params
12 checks passed
ezilber-akamai
added a commit
that referenced
this pull request
May 21, 2025
* Added support for DB Configurable Params (#527) * Added support for DB Configurable Params features * Added unit tests for config endpoints * Added more unit tests and removed config_update methods * Removed stale fields and updated unit tests * Add integration tests * Add integration tests * remove unused var * remove comments and update test case * update test case * remove assertion * Added support for custom JSON field names in dataclasses * Minor integration test fixes * add get and list test cases --------- Co-authored-by: Youjung Kim <ykim@akamai.com> * Add / prefix to URL in mysql_config_options and postgresql_config_options API calls (#542) * add test coverage for nullable fields (#541) --------- Co-authored-by: Youjung Kim <ykim@akamai.com> Co-authored-by: Lena Garber <114949949+lgarber-akamai@users.noreply.github.com> Co-authored-by: Youjung Kim <126618609+ykim-akamai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This pull request adds a
/prefix to the API request paths in theDatabaseGroup(...).mysql_config_options(...)andDatabaseGroup(...).postgresql_config_options(...), which resolves the following error that occurs when attempting to call these methods from an external consumer:✔️ How to Test
The following test steps assume you have pulled down this PR locally and run
make install.Unit Testing
Integration Testing