Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate new testing server certificate and add docs #81

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Generate new testing server certificate and add docs #81

merged 1 commit into from
Nov 11, 2020

Conversation

thorn3r
Copy link
Contributor

@thorn3r thorn3r commented Nov 10, 2020

  • Generate new testing cert with Subject Alternate Name (SAN) using the testing CA.
  • Add documentation to testing README explaining how to mint a new cert.
  • Add Certificate Signing Request (CSR) to certificates directory for use in generating future certs.

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

- Generate new testing cert with Subject Alternate Name (SAN) using t…
0d75b91 
…he testing CA.

- Add documentation to testing README explaining how to mint a new cert.
- Add Certificate Signing Request (CSR) to certificates directory for use in generating future certs.
0xch4z
0xch4z approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@0xch4z 0xch4z left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@0xch4z 0xch4z requested a review from phillc November 10, 2020 17:04
@0xch4z 0xch4z merged commit 44d4483 into linode:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xch4z 0xch4z 0xch4z approved these changes

@phillc phillc Awaiting requested review from phillc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thorn3r @0xch4z