Ensure rebuild options are captured correctly if NodeBalancer config exists #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorn3r
force-pushed
the
fixLoadbalancerUpdateConfig
branch
2 times, most recently
from
c6e8a2e to
7fe7469
Compare
phillc
reviewed
Mar 5, 2020
cloud/linode/loadbalancers_test.go
Outdated
| @@ -204,6 +204,85 @@ func testUpdateLoadBalancerAddAnnotation(t *testing.T, client *linodego.Client) | |||
| } | |||
| } | |||
|
|
|||
| func testUpdateLoadBalancerAddPortAnnotation(t *testing.T, client *linodego.Client) { | |||
| targetTestPort := 80 | |||
| portConfigAnnotation = fmt.Sprintf("%s-%i", annLinodePortConfigPrefix, targetTestPort) | |||
There was a problem hiding this comment.
I fixed this locally and the test didn't fail if I removed the code change.
thorn3r
force-pushed
the
fixLoadbalancerUpdateConfig
branch
2 times, most recently
from
9870689 to
d59a0d5
Compare
thorn3r
force-pushed
the
fixLoadbalancerUpdateConfig
branch
from
d59a0d5 to
2f888af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General:
Bugfix: Updating NodeBalancer port configs is broken. If you attempt to update a port configuration, the NodeBalancer does not update.
This PR addresses this and ensures NodeBalancer port configs are updated correctly.