-
Notifications
You must be signed in to change notification settings - Fork 68
feat(helm): add podAnnotations and podLabels #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
=======================================
Coverage 74.41% 74.41%
=======================================
Files 16 16
Lines 2865 2865
=======================================
Hits 2132 2132
Misses 550 550
Partials 183 183 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2b81ae7
to
09e9490
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces new configuration options for customizing pod annotations and labels in the Helm chart.
- Adds default empty values for podAnnotations and podLabels in values.yaml
- Incorporates these values into the daemonset template to allow dynamic annotation and label injection
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
deploy/chart/values.yaml | Added configuration entries for podAnnotations and podLabels |
deploy/chart/templates/daemonset.yaml | Injects the new podAnnotations and podLabels into daemonset metadata |
Comments suppressed due to low confidence (2)
deploy/chart/values.yaml:124
- [nitpick] Consider expanding this comment to provide more context on how podAnnotations and podLabels interact with the chart templates.
# Add podAnnotations and podLabels for customization
deploy/chart/templates/daemonset.yaml:23
- [nitpick] Verify that the indentation level for the injected 'annotations:' field meets the desired YAML structure, ensuring consistency with other metadata fields.
{{- with .Values.podAnnotations }}
09e9490
to
3dee7ca
Compare
09e9490
to
c4c6b31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
General:
Pull Request Guidelines: