Skip to content

feat(helm): add podAnnotations and podLabels #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Conversation

guilhem
Copy link
Contributor

@guilhem guilhem commented Jun 4, 2025

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.41%. Comparing base (56b28b1) to head (c4c6b31).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #396   +/-   ##
=======================================
  Coverage   74.41%   74.41%           
=======================================
  Files          16       16           
  Lines        2865     2865           
=======================================
  Hits         2132     2132           
  Misses        550      550           
  Partials      183      183           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guilhem guilhem requested a review from Copilot June 4, 2025 10:30
Copilot

This comment was marked as outdated.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces new configuration options for customizing pod annotations and labels in the Helm chart.

  • Adds default empty values for podAnnotations and podLabels in values.yaml
  • Incorporates these values into the daemonset template to allow dynamic annotation and label injection

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
deploy/chart/values.yaml Added configuration entries for podAnnotations and podLabels
deploy/chart/templates/daemonset.yaml Injects the new podAnnotations and podLabels into daemonset metadata
Comments suppressed due to low confidence (2)

deploy/chart/values.yaml:124

  • [nitpick] Consider expanding this comment to provide more context on how podAnnotations and podLabels interact with the chart templates.
# Add podAnnotations and podLabels for customization

deploy/chart/templates/daemonset.yaml:23

  • [nitpick] Verify that the indentation level for the injected 'annotations:' field meets the desired YAML structure, ensuring consistency with other metadata fields.
{{- with .Values.podAnnotations }}

Copy link
Collaborator

@rahulait rahulait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahulait rahulait merged commit b71ad09 into main Jun 5, 2025
10 of 11 checks passed
hcwagner pushed a commit to hcwagner/linode-cloud-controller-manager that referenced this pull request Jun 11, 2025
@rahulait rahulait deleted the annotationsandlabels branch June 18, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants