Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Terroform to CAPL provider for E2E testing #201

Closed
wants to merge 6 commits into from
Closed

Replace Terroform to CAPL provider for E2E testing #201

wants to merge 6 commits into from

Conversation

mhmxs
Copy link
Contributor

@mhmxs mhmxs commented Apr 11, 2024 •
edited
Loading

Terraform provider of Linode has been deprecated. This change replaces Terraform to Linode CAPI provider.

Fixes: #165

Currently e2e tests are failing, the reason is under investigation, but the cluster infra looks good.

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@mhmxs mhmxs force-pushed the terraform-2-capl branch 2 times, most recently from 973d81e to c95c741 Compare April 12, 2024 07:00
@mhmxs mhmxs marked this pull request as ready for review April 12, 2024 07:12
@mhmxs mhmxs added the on-hold label Apr 12, 2024
@mhmxs mhmxs force-pushed the terraform-2-capl branch 5 times, most recently from 473babb to dbbc66c Compare April 15, 2024 10:49
mhmxs
mhmxs commented Apr 15, 2024
View reviewed changes
e2e/test/ccm_suite_test.go Outdated Show resolved Hide resolved
@mhmxs mhmxs force-pushed the terraform-2-capl branch 3 times, most recently from bcb1370 to 4c7159e Compare April 15, 2024 11:46
@mhmxs mhmxs force-pushed the terraform-2-capl branch from 4c7159e to 41da5d6 Compare April 15, 2024 12:25
mhmxs
mhmxs commented Apr 15, 2024
View reviewed changes
e2e/test/ccm_e2e_test.go
Expect(err).NotTo(HaveOccurred())
Expect(len(workers)).Should(BeNumerically(">=", 2))
Expect(workers).Should(HaveLen(2))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without his change, we can't guarantee the correctness of scaling test.

@mhmxs mhmxs force-pushed the terraform-2-capl branch from 41da5d6 to 89d8b91 Compare April 15, 2024 12:37
mhmxs
mhmxs commented Apr 22, 2024
View reviewed changes
e2e/Makefile Outdated Show resolved Hide resolved
@mhmxs mhmxs removed the on-hold label Apr 24, 2024
@mhmxs mhmxs requested a review from eljohnson92 April 24, 2024 03:51
@mhmxs mhmxs requested a review from eljohnson92 April 26, 2024 02:39
@mhmxs mhmxs force-pushed the terraform-2-capl branch from 41876ff to d481f82 Compare April 26, 2024 02:46
@rahulait
Copy link
Collaborator

Similar changes are done in #248. This PR can be closed.

@mhmxs mhmxs closed this Nov 28, 2024
@mhmxs mhmxs reopened this Nov 28, 2024
@rahulait
Copy link
Collaborator

rahulait commented Dec 9, 2024

All the e2e tests are also converted to chainsaw in PR #253
@mhmxs is there anything specific for which this PR might be required? I am planning to close all stale PRs to keep repo in clean state and wanted to check if this PR can be closed as it was closed and reopened.

@rahulait
Copy link
Collaborator

Chainsaw PR is merged. We can close this PR

@rahulait
Copy link
Collaborator

Closing the PR as this is implemented in other PRs.

@rahulait rahulait closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avestuk avestuk Awaiting requested review from avestuk

@scmeggitt scmeggitt Awaiting requested review from scmeggitt

@akaokunc akaokunc Awaiting requested review from akaokunc

@okokes-akamai okokes-akamai Awaiting requested review from okokes-akamai

@luthermonson luthermonson Awaiting requested review from luthermonson

@eljohnson92 eljohnson92 Awaiting requested review from eljohnson92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replacing Terraform to Linode CAPI provider
4 participants
@mhmxs @rahulait @eljohnson92 @avestuk