Skip to content

Conversation

ykim-akamai
Copy link
Contributor

@ykim-akamai ykim-akamai commented Mar 20, 2025

πŸ“ Description

Adding integration tests for all available commands under object-storage:

β”‚ clusters-list β”‚ List clusters.                                
β”‚ clusters-view β”‚ Get a cluster.                                
β”‚ keys-create   β”‚ Create an Object Storage key.                 
β”‚ keys-delete   β”‚ Revoke an Object Storage key.                 
β”‚ keys-list     β”‚ List Object Storage keys.                     
β”‚ keys-update   β”‚ Update an Object Storage key.                 
β”‚ keys-view     β”‚ Get an Object Storage key.                    
β”‚ types         β”‚ List Object Storage types.                    
β”‚ endpoints                   β”‚ List Object Storage endpoints.                
β”‚ get-object-storage-transfer β”‚ Get Object Storage transfer data.             

βœ”οΈ How to Test

TEST_SUITE=obj make test-int

πŸ“· Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@ykim-akamai ykim-akamai added the testing for updates to the testing suite in the changelog. label Mar 20, 2025
@ykim-akamai ykim-akamai requested a review from a team as a code owner March 20, 2025 21:28
@ykim-akamai ykim-akamai requested review from yec-akamai and ezilber-akamai and removed request for a team March 20, 2025 21:28
@ykim-akamai ykim-akamai marked this pull request as draft March 20, 2025 21:31
@ykim-akamai ykim-akamai marked this pull request as ready for review March 24, 2025 15:54
Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting a test failure in test_generate_url that says:

FAILED tests/integration/obj/test_obj_plugin.py::test_generate_url - assert '<?xml versio...stId></Error>' == 'Hello, World!'

Are you seeing this locally?

@ykim-akamai
Copy link
Contributor Author

ykim-akamai commented Mar 25, 2025

I'm getting a test failure in test_generate_url that says:

FAILED tests/integration/obj/test_obj_plugin.py::test_generate_url - assert '<?xml versio...stId></Error>' == 'Hello, World!'

Are you seeing this locally?

Good catch! I don't think this is caused from changes in this PR but I will provide an update shortly if it requires a fix

Update: Failure was from extra line at the end of the URL. Should be fixed in latest commit

Copy link
Contributor

@ezilber-akamai ezilber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passing now!

Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests all passed locally, nice work!

@ykim-akamai ykim-akamai merged commit 5612fe9 into linode:dev Apr 2, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants