-
Notifications
You must be signed in to change notification settings - Fork 149
Add object-storage integration tests #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add object-storage integration tests #750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting a test failure in test_generate_url
that says:
FAILED tests/integration/obj/test_obj_plugin.py::test_generate_url - assert '<?xml versio...stId></Error>' == 'Hello, World!'
Are you seeing this locally?
Good catch! I don't think this is caused from changes in this PR but I will provide an update shortly if it requires a fix Update: Failure was from extra line at the end of the URL. Should be fixed in latest commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests passing now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests all passed locally, nice work!
π Description
Adding integration tests for all available commands under object-storage:
βοΈ How to Test
TEST_SUITE=obj make test-int
π· Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.