test: Add Linode Cloud Firewall for all test linode instances #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykim-akamai
requested review from
jriddle-linode and
zliang-akamai
and removed request for
a team
ykim-akamai
commented
May 24, 2024
| ipv4_address = get_public_ip("ipv4") | ||
| ipv6_address = get_public_ip("ipv6") | ||
|
|
||
| inbound_rule = create_inbound_rule(ipv4_address, ipv6_address) |
There was a problem hiding this comment.
Firewall will automatically pick up ipv4 and ipv6 of machine under test and add them in inbound_rule
ykim-akamai
commented
May 24, 2024
tests/integration/conftest.py
Outdated
| "--rules.outbound_policy", | ||
| "ACCEPT", | ||
| "--rules.inbound_policy", | ||
| "DROP", |
There was a problem hiding this comment.
Default policy is to DROP all inbound traffic
ykim-akamai
commented
May 24, 2024
| "id", | ||
| ] | ||
|
|
||
| if is_valid_ipv4(ipv4_address) or is_valid_ipv6(ipv6_address): |
There was a problem hiding this comment.
Default Firewall will be created if valid IP wasn't found
zliang-akamai
approved these changes
May 24, 2024
jriddle-linode
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR implements Linode Cloud Firewall for integration tests to enhance security.
Default Inbound policy: DROP
Default Outbound policy: ACCEPT
Inbound rule: inbound rule with public ip on port 22
Note: GHA does not support ipv6 so only ipv4 will get added in firewall during GHA execution. However, ipv6 will get added automatically if ipv6 address and route exist
✔️ How to Test
make testinthttps://github.com/linode/linode-cli/actions/runs/9217506829
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.