fix: Resolve help page error for list commands with non-standard names #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarber-akamai
requested review from
ykim-akamai and
yec-akamai
and removed request for
a team
lgarber-akamai
force-pushed
the
fix/domain-records-list-help
branch
from
825804d
to
8f05438
Compare
yec-akamai
approved these changes
Mar 13, 2024
zliang-akamai
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This change resolves an error that would occur when attempting to view the help page for certain commands with non-standard action names (e.g.
domains records-list --help). This issue occurred because the branch condition for list commands explicitly checked for an action with the namelistwhich isn't met by some list commands, leading to this code path being run and raising an error.Resolves #581
✔️ How to Test
The following test steps assume you have pulled down this PR locally and run
make install.Integration Testing
Manual Testing