Do not attach volume to current Linode on creation#47
Merged
LBGarber merged 1 commit intolinode:mainfrom Oct 28, 2021
Merged
Conversation
LBGarber
force-pushed
the
no-create-attach
branch
from
f2ede50 to
f52e8a4
Compare
Collaborator
|
is driver.Region going to be set without a existing Linode setup? |
Contributor
Author
Region is only set when the driver is running on a Linode, but this should still work considering the region is also implicitly determined when creating a volume using the Linode ID. 👍 |
jriddle-linode
approved these changes
Oct 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attaching a volume after creation on the current Linode can lead to attachment issues if
force-attach=false. When a volume is mounted, it will automatically be attached to the correct Linode.