Merged
Conversation
Contributor
Author
|
By fetching the region from the instance, instead of taking it as a user parameter, we also avoid the potential issue of a user supplied region being an alias region, which the volume list filter-by-region poll would never resolve: docker-volume-linode/driver.go Line 391 in be8f94b I encountered this a few times when using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a few issues
linode-regionoption, redundant tolinode-label(Closes Must provide a region or a Linode ID #24)volume rm(Closes Remove docker volume without removing the physical volume #23)volume createoption to delete Linode volumes onvolume rm