Utilize metadata service to get Linode info; Wait for Volume Active on Creation#146
Merged
zliang-akamai merged 7 commits intolinode:mainfrom Apr 10, 2024
Conversation
zliang-akamai
requested review from
jriddle-linode and
lgarber-akamai
and removed request for
a team
zliang-akamai
changed the title
lgarber-akamai
approved these changes
Apr 4, 2024
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Works well on my end, nice work!
jriddle-linode
approved these changes
Apr 9, 2024
Collaborator
jriddle-linode
left a comment
jriddle-linode
left a comment
There was a problem hiding this comment.
LGTM. works locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This is to implement logic that retrieve Linode info from metadata service, and if failed, fall back to original hacking way for the regions that don't have metadata services enabled.
✔️ How to Test
Automated Testing
You can do
make int-testif we can merge #145 before this PR.Manually Testing
us-mia) and a Linode in an old site (e.g.us-central).LINODE_TOKEN=<YOUR_TOKEN> PLUGIN_VERSION=dev make testmake builddocker plugin set linode/docker-volume-linode:latest linode-token=<YOUR_TOKEN>docker plugin enable linode/docker-volume-linode:latestdocker volume create -d linode/docker-volume-linode:latest -o delete-on-remove=true test-volume-default-size