Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use platform-admin group instead of team-admin #1762

Merged
merged 2 commits into from
Oct 15, 2024
Merged

fix: use platform-admin group instead of team-admin #1762

merged 2 commits into from
Oct 15, 2024

Conversation

j-zimnowoda
Copy link
Contributor

No description provided.

Ani1357
Ani1357 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@Ani1357 Ani1357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by upgrading an existing cluster based on main.
It solves the issue with Argo not being able to see apps.

@j-zimnowoda j-zimnowoda enabled auto-merge (squash) October 15, 2024 13:32
ferruhcihan
ferruhcihan approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j-zimnowoda j-zimnowoda merged commit fdbd80d into main Oct 15, 2024
5 checks passed
@j-zimnowoda j-zimnowoda deleted the APL-221 branch October 15, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ani1357 Ani1357 Ani1357 approved these changes

@ferruhcihan ferruhcihan ferruhcihan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-zimnowoda @Ani1357 @ferruhcihan