-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve installer job feedback #1755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! The code is clean and easy to follow. I tested it with a cluster 👍🏻 and it works.
I have a few comments, especially regarding the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First Job Pod has failed due the following errors
2024-10-16T08:41:01.095Z otomi:cmd:bootstrap:bootstrapGit:info Git repo was already bootstrapped, setting identity just in case
2024-10-16T08:41:01.168Z otomi:common:k8s:waitTillGitRepoAvailable:warn fatal: unable to access 'http://gitea-http.gitea.svc.cluster.local:3000/otomi/values.git/': Could not resolve host: gitea-http.gitea.svc.cluster.local
at /home/app/stack/dist/src/common/k8s.js:190:31
exit code: 128 (Invalid exit argument)
2024-10-16T08:41:02.328Z otomi:common:k8s:waitTillGitRepoAvailable:warn remote: Not found.
fatal: repository 'http://gitea-http.gitea.svc.cluster.local:3000/otomi/values.git/' not found
at /home/app/stack/dist/src/common/k8s.js:190:31
exit code: 128 (Invalid exit argument)
....
2024-10-16T08:41:09.351Z otomi:cmd:commit:pipelineRun:info There is a Tekton PipelineRuns continuing...
2024-10-16T08:41:09.353Z otomi:cmd:commit:isOAuth2ProxyRunning:info Checking if OAuth2Proxy is running, waiting...
2024-10-16T08:41:19.447Z otomi:cmd:commit:isOAuth2ProxyRunning:info Checking if OAuth2Proxy is running, waiting...
2024-10-16T08:41:34.462Z otomi:cmd:commit:isOAuth2ProxyRunning:info Checking if OAuth2Proxy is running, waiting...
2024-10-16T08:41:56.995Z otomi:cmd:commit:isOAuth2ProxyRunning:info Checking if OAuth2Proxy is running, waiting...
2024-10-16T08:42:30.792Z otomi:cmd:commit:isOAuth2ProxyRunning:info Checking if OAuth2Proxy is running, waiting...
2024-10-16T08:43:21.475Z otomi:cmd:commit:isOAuth2ProxyRunning:info Checking if OAuth2Proxy is running, waiting...
2024-10-16T08:44:37.502Z otomi:cmd:commit:isOAuth2ProxyRunning:info Checking if OAuth2Proxy is running, waiting...
2024-10-16T08:46:31.647Z otomi:cmd:commit:isOAuth2ProxyRunning:info Checking if OAuth2Proxy is running, waiting...
2024-10-16T08:49:22.618Z otomi:cmd:commit:isOAuth2ProxyRunning:info Checking if OAuth2Proxy is running, waiting...
2024-10-16T08:53:39.021Z otomi:cmd:commit:isOAuth2ProxyRunning:info Checking if OAuth2Proxy is running, waiting...
2024-10-16T09:00:03.563Z otomi:cmd:commit:isOAuth2ProxyRunning:info Checking if OAuth2Proxy is running, waiting...
2024-10-16T09:00:03.578Z otomi:cmd:commit:isOAuth2ProxyRunning:error Error checking if OAuth2Proxy is ready: HttpError: HTTP request failed
at Request._callback (/home/app/stack/node_modules/@kubernetes/client-node/dist/gen/api/appsV1Api.js:4142:36)
body: {
kind: 'Status',
apiVersion: 'v1',
metadata: {},
status: 'Failure',
message: 'deployments.apps "oauth2-proxy" not found',
reason: 'NotFound',
details: { name: 'oauth2-proxy', group: 'apps', kind: 'deployments' },
code: 404
},
statusCode: 404
then second Job Pod has not printed message with the instruction.
I also spotted an undefined variable in logs
2024-10-16T09:00:03.760Z otomi:cmd:apply:apply:info Retrying in undefined ms
Checklist