-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: user management #1740
Merged
Merged
feat: user management #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferruhcihan
requested review from
j-zimnowoda,
ElderMatt,
srodenhuis and
merll
and removed request for
merll,
j-zimnowoda,
ElderMatt and
srodenhuis
September 30, 2024 14:48
ElderMatt
requested changes
Oct 7, 2024
j-zimnowoda
requested changes
Oct 7, 2024
j-zimnowoda
reviewed
Oct 7, 2024
j-zimnowoda
reviewed
Oct 10, 2024
j-zimnowoda
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
ElderMatt
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
https://jira.linode.com/browse/APL-27
https://jira.linode.com/browse/APL-221
https://jira.linode.com/browse/APL-229
Description
This PR adds user schema into the values-schema and updates the values files.
Is paired with:
Console => https://github.com/linode/apl-console/pull/441
Api => https://github.com/linode/apl-api/pull/565
Tasks => linode/apl-tasks#118
Docs => linode/apl-docs#76
Checklist
adr/*.md
and appended to list inadr/_index.md
, if applicable.values-schema.yaml
file andtest/**
fixtures have been updated to reflect code changes, if applicable.values-schema.yaml
file, if applicable.