Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loki storage config without OBJ #1680

Merged
merged 5 commits into from
Aug 20, 2024
Merged

fix: loki storage config without OBJ #1680

merged 5 commits into from
Aug 20, 2024

Conversation

srodenhuis
Copy link
Contributor

When OBJ is not configured (or set to disabled), the Loki storageConfig is now configured to use filesystem. This allows to use Loki without OBJ.

@ElderMatt
Copy link
Contributor

At the moment the validate-templates is failing on the following:
image

@ElderMatt
Copy link
Contributor

It fixes the Loki errors, but when performing full install it does give the following error for velero. Is this something we want to fix in this PR or make a new PR for it?
image

Copy link
Contributor

@ElderMatt ElderMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElderMatt ElderMatt merged commit 5c2b76d into main Aug 20, 2024
7 checks passed
@ElderMatt ElderMatt deleted the sr-fix-loki-no-obj branch August 20, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants