Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bootstrap default values #1659

Merged
merged 19 commits into from
Aug 5, 2024
Merged

feat: bootstrap default values #1659

merged 19 commits into from
Aug 5, 2024

Conversation

CasLubbers
Copy link
Contributor

Default values are stored in different places (projects). We want to adhere to single source of truth design pattern and store all values in Gitea.

@CasLubbers CasLubbers force-pushed the cas-bootstrap-default branch 3 times, most recently from 1a90e0c to 0e30eab Compare July 26, 2024 10:24
@CasLubbers CasLubbers marked this pull request as ready for review August 1, 2024 07:42
@j-zimnowoda
Copy link
Contributor

I performed some tests with bootstrapping the values with

npm run bootstrap-dev
# and 
npm run bootstrap-dev-with-repo

contributed one fix and now it is looking good.

@j-zimnowoda j-zimnowoda self-requested a review August 5, 2024 08:59
Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO we should not store letsencryptCA and letsencryptRootCA in the values.
Perhaps moving them to derived.gotmpl is a good way to go.

@j-zimnowoda j-zimnowoda merged commit cf1bf3c into main Aug 5, 2024
7 checks passed
@j-zimnowoda j-zimnowoda deleted the cas-bootstrap-default branch August 5, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants