-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bootstrap default values #1659
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasLubbers
force-pushed
the
cas-bootstrap-default
branch
3 times, most recently
from
July 26, 2024 10:24
1a90e0c
to
0e30eab
Compare
CasLubbers
force-pushed
the
cas-bootstrap-default
branch
from
July 31, 2024 11:33
6a27c21
to
b0c176e
Compare
j-zimnowoda
reviewed
Aug 1, 2024
I performed some tests with bootstrapping the values with
contributed one fix and now it is looking good. |
j-zimnowoda
approved these changes
Aug 2, 2024
j-zimnowoda
reviewed
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO we should not store letsencryptCA and letsencryptRootCA in the values.
Perhaps moving them to derived.gotmpl is a good way to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default values are stored in different places (projects). We want to adhere to single source of truth design pattern and store all values in Gitea.