Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove shortcuts #1637

Merged
merged 10 commits into from
Jul 9, 2024
Merged

feat: remove shortcuts #1637

merged 10 commits into from
Jul 9, 2024

Conversation

dennisvankekem
Copy link
Contributor

Checklist

  • Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md, if applicable.
  • The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
  • The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file, if applicable.
  • Helm releases are meeting otomi's baseline security policies, if applicable.
  • Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

@dennisvankekem dennisvankekem changed the title Feat/remove shortcuts feat: remove shortcuts Jul 4, 2024
Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide migrations in the values-changes.yaml file

Copy link
Collaborator

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dennisvankekem
Copy link
Contributor Author

tested locally. Also, @j-zimnowoda would the way it's noted in values-changes.yaml suffice? Or is it worth it to update migrate.ts to include an {app} wildcard and iterate through it in unparsePaths in the case we need to add/remove something from all apps?

Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just update version in the helmfile.d/snippets/defaults.yaml file to

        version: 24

@dennisvankekem dennisvankekem enabled auto-merge (squash) July 9, 2024 14:17
@dennisvankekem dennisvankekem merged commit 096d9a1 into main Jul 9, 2024
4 checks passed
@dennisvankekem dennisvankekem deleted the feat/remove-shortcuts branch July 9, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants