-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove shortcuts #1637
feat: remove shortcuts #1637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide migrations in the values-changes.yaml
file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tested locally. Also, @j-zimnowoda would the way it's noted in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just update version in the helmfile.d/snippets/defaults.yaml file to
version: 24
Checklist
adr/*.md
and appended to list inadr/_index.md
, if applicable.values-schema.yaml
file andtest/**
fixtures have been updated to reflect code changes, if applicable.values-schema.yaml
file, if applicable.