Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add trusted root certificates to images #1620

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Conversation

merll
Copy link
Contributor

@merll merll commented Jun 4, 2024

The images otomi-tools and otomi-core are missing the CA trust store provided by the base image's distribution (Ubuntu). The package is installed but the files are not transferred to the final image. Therefore, contacting any HTTPS site fails unless the verification is deactivated.

This PR adds the /etc/ssl directory from the base image, fixing this issue.

@j-zimnowoda
Copy link
Contributor

Very good catch!

@j-zimnowoda j-zimnowoda changed the title fix: add trusted root certificates to images fix: add trusted root certificates to images [TOOLS][PATCH] Jun 4, 2024
@j-zimnowoda j-zimnowoda self-requested a review June 4, 2024 09:28
@j-zimnowoda
Copy link
Contributor

I added the [TOOLS][PATCH] to the PR message, so our build pipeline is triggered.
There is already v2.0.3 in dockerhub

@j-zimnowoda j-zimnowoda changed the title fix: add trusted root certificates to images [TOOLS][PATCH] fix: add trusted root certificates to images Jun 4, 2024
@j-zimnowoda j-zimnowoda merged commit 4dbb03e into main Jun 4, 2024
11 checks passed
@j-zimnowoda j-zimnowoda deleted the me-fix-trusted-roots branch June 4, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants