Skip to content

Add Positive static properties to Range class #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add Positive static properties to Range class #89

wants to merge 3 commits into from

Conversation

@konard
Copy link
Member

@konard konard commented Sep 14, 2025 •
edited
Loading

Summary

  • Implements issue Add Positive static properties to Range class #30 by adding static positive range properties to the Range class
  • Added Range.PositiveInt64 property to replace (1L, long.MaxValue) tuple pattern
  • Added consistent positive range properties for other integer types: PositiveInt32, PositiveInt16, PositiveSByte
  • Added comprehensive unit tests verifying all new properties work correctly

Changes

  • csharp/Platform.Ranges/Range.cs: Added 4 new static readonly properties for positive ranges
  • csharp/Platform.Ranges.Tests/RangeTests.cs: Added PositiveRangesTest method to verify functionality

Test plan

  • All existing tests continue to pass
  • New test method PositiveRangesTest verifies correct minimum and maximum values for all positive range properties
  • Build completes successfully with no errors or warnings
  • Implementation follows existing code patterns and documentation style

🤖 Generated with Claude Code

Resolves #30

@konard
Initial commit with task details for issue #30
7ffb903 
Adding CLAUDE.md with task information for AI processing.
This file will be removed when the task is complete.

Issue: #30
@konard konard self-assigned this Sep 14, 2025
@konard @claude
Add Positive static properties to Range class
af05744 
Implements issue #30 by adding PositiveInt64, PositiveInt32, PositiveInt16, and PositiveSByte static properties to the Range class. These properties provide ranges starting from 1 to the respective maximum values, replacing the need for tuple patterns like (1L, long.MaxValue).

- Added Range.PositiveInt64 for (1L, long.MaxValue) replacement
- Added Range.PositiveInt32, PositiveInt16, PositiveSByte for consistency
- Added comprehensive unit tests for all new positive range properties
- All tests pass and build is successful

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@konard konard changed the title [WIP] Add Positive static properties to Range class Add Positive static properties to Range class Sep 14, 2025
@konard konard marked this pull request as ready for review September 14, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@konard konard

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Positive static properties to Range class

2 participants

@konard