Replace with Random.Shared from .NET 6 #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #53
- Changed RandomHelpers.Default from custom Random instance with DateTime.UtcNow.Ticks seed to use System.Random.Shared - Updated documentation to reflect thread-safe nature of Random.Shared - Incremented version to 0.4.0 for next release - Updated package release notes - All existing tests pass with the new implementation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Randominstance usingDateTime.UtcNow.Ticks.GetHashCode()seed withRandom.Sharedfrom .NET 6+Random.SharedBenefits
Random.Sharedprovides built-in thread safety, eliminating potential issues with concurrent accessTest Results
All existing tests pass with the new implementation:
DefaultFieldTest- Verifies the Default field is not nullNextUInt64Test- Verifies random UInt64 generation with rangesNextBooleanTest- Verifies random boolean generationThe change maintains backward compatibility while providing the benefits of the modern .NET 6+ approach.
🤖 Generated with Claude Code
Resolves #53