Skip to content

Move restrictions before substitution in Update method #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Move restrictions before substitution in Update method #152

wants to merge 3 commits into from

Conversation

konard
Copy link
Member

@konard konard commented Sep 12, 2025 •
edited
Loading

Summary

  • Added a new variadic template Update method to ILinksExtensions.h that properly handles parameter order
  • The new method takes a substitution and variadic restrictions, then calls the base Update method with restrictions before substitution
  • Added a test case to verify the new method works correctly

Test plan

  • Added test case in ILinksTests.cpp to verify the new Update method
  • Verified the method follows the same pattern as other variadic template methods in the file
  • Confirmed the method calls the base Update method with correct parameter order (restrictions before substitution)

Fixes #113

🤖 Generated with Claude Code

@konard
Initial commit with task details for issue #113
b9bb2fe 
Adding CLAUDE.md with task information for AI processing.
This file will be removed when the task is complete.

Issue: #113
@konard konard self-assigned this Sep 12, 2025
@konard @claude
Add Update method with variadic restrictions to fix parameter order i…
5111329 
…ssue

Added a new variadic template Update method that properly calls the base Update method
with restrictions before substitution, resolving issue #113. Also added a test for the
new method to ensure it works correctly.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@konard konard changed the title [WIP] Move restrictions before substitution Move restrictions before substitution in Update method Sep 12, 2025
@konard konard marked this pull request as ready for review September 12, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@konard konard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move restrictions before substitution
1 participant
@konard