Investigation: Remove DisposableWithMultipleCallsAllowed inner class when Platform.Disposables supports constructor override

[konard]

🔍 Investigation Report

This PR tracks the resolution of issue #122, which requests the removal of the DisposableWithMultipleCallsAllowed inner class once the upstream Platform.Disposables library supports constructor-based override of AllowMultipleDisposeCalls.

📋 Issue Reference

Relates to #122
Depends on linksplatform/Disposables#35

---

🔎 Investigation Findings

Current Situation

Data.Doublets (this repository):

• Currently uses Platform.Disposables version 0.4.0 (via transitive dependency)
• Contains workaround inner class DisposableWithMultipleCallsAllowed in LinksDisposableDecoratorBase.cs (lines 94-120)
• This workaround is necessary because the current version of Platform.Disposables doesn't support constructor-based override

Platform.Disposables dependency:

• Latest NuGet release: 0.4.0 (released December 15, 2022)
• Target framework: .NET 7 (now updated to .NET 8 in main branch)
• Issue Use group expression instead #35 is still open (created Feb 24, 2020, no updates)
• PR #95 exists with the solution but is not yet merged

PR #95 Status in Disposables Repository

✅ Good news: A complete solution exists!

PR #95 in the Disposables repository:

• Title: "Add constructor overloads to override AllowMultipleDisposeCalls and AllowMultipleDisposeAttempts"
• Status: Open (created September 14, 2025)
• Author: konard
• Changes:
  • Adds constructor parameters allowMultipleDisposeCalls and allowMultipleDisposeAttempts to all Disposable constructors
  • Includes comprehensive tests (11/11 passing)
  • Fully backward compatible
  • Ready to merge

Before (current workaround):

protected class DisposableWithMultipleCallsAllowed : Disposable
{
    public DisposableWithMultipleCallsAllowed(Disposal disposal) : base(disposal) { }
    protected override bool AllowMultipleDisposeCalls => true;
}

After (when PR #95 is merged and released):

var disposable = new Disposable(disposal, allowMultipleDisposeCalls: true);

---

⏳ Blocking Factors

This issue cannot be resolved yet because:

1. ❌ PR #95 in Disposables repository is not merged
2. ❌ No new version of Platform.Disposables has been released since 0.4.0 (Dec 2022)
3. ❌ The required feature is not available in any published NuGet package

---

✅ Action Plan

To resolve this issue, the following steps must occur in order:

Upstream (Platform.Disposables repository):

1. ✅ Solution implemented in PR #95 (already done)
2. ⏸️ WAITING: PR #95 needs to be reviewed and merged
3. ⏸️ WAITING: New version needs to be released to NuGet (e.g., 0.5.0)

Downstream (this repository - Data.Doublets):

4. ⏸️ Update Platform.Disposables dependency to new version (≥0.5.0)
5. ⏸️ Remove DisposableWithMultipleCallsAllowed inner class from LinksDisposableDecoratorBase.cs
6. ⏸️ Update constructor to use new Disposable(disposal, allowMultipleDisposeCalls: true) syntax
7. ⏸️ Test all changes
8. ⏸️ Close issue Remove this inner class, when Disposable class start support AllowMultipleDisposeCalls value overriding #122

---

📝 Recommendations

For Platform.Disposables maintainers:

• Review and merge PR #95 (Add constructor overloads to override AllowMultipleDisposeCalls and AllowMultipleDisposeAttempts Disposables#95)
• Create a new release (0.5.0 or later) with the new constructor feature
• Publish to NuGet

For Data.Doublets maintainers:

• Keep this PR and issue Remove this inner class, when Disposable class start support AllowMultipleDisposeCalls value overriding #122 open until the dependency is resolved
• Monitor Add constructor overloads to override AllowMultipleDisposeCalls and AllowMultipleDisposeAttempts Disposables#95 for merge status
• Once merged and released, proceed with implementation steps 4-8 above

---

📚 References

• This issue: Remove this inner class, when Disposable class start support AllowMultipleDisposeCalls value overriding #122
• Upstream issue: Add constructor that can override values of AllowMultipleDisposeCalls and AllowMultipleDisposeAttempts properties Disposables#35
• Upstream solution PR: Add constructor overloads to override AllowMultipleDisposeCalls and AllowMultipleDisposeAttempts Disposables#95
• Current workaround location: /csharp/Platform.Data.Doublets/Decorators/LinksDisposableDecoratorBase.cs:94-120
• NuGet package: https://www.nuget.org/packages/Platform.Disposables/

---

Status: This PR will remain in draft until the upstream dependency provides the required feature.

🤖 Generated with Claude Code

Fixes #122

[konard]

🤖 Solution Draft Log

This log file contains the complete execution trace of the AI solution draft process.

📎 Log file uploaded as GitHub Gist (188KB)
🔗 View complete solution draft log

---

Now working session is ended, feel free to review and add any feedback on the solution draft.