Fix #14: Optimize heap allocation to improve performance #505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #14 by optimizing memory allocation patterns in the
ILinksExtensions.csfile to improve performance.Changes Made
DeleteAllUsagesmethod: Replaced dynamicList<IList<TLinkAddress>?>allocation with pre-sized arrays for collections with ≤128 itemsDeleteByQuerymethod: Similar optimization using bounded arrays instead of dynamic lists for small result setsPerformance Improvements
Testing
Background
The original issue referenced using
stackallocinstead ofArrayPool.Allocate. While the specificLinksCascadeDependenciesResolverfile mentioned in the issue was refactored in previous commits, this PR addresses the same underlying performance concern by optimizing similar allocation patterns found in the current codebase.The optimization targets methods that:
Technical Details
Instead of using
stackalloc(which doesn't work with generic type parameters), this implementation:List<>for larger collectionsThis approach provides the performance benefits of stack-like allocation while maintaining compatibility with generic constraints and large data sets.
🤖 Generated with Claude Code
Resolves #14