Ensure minimum visible bar width for small values in benchmark graph#10
Merged
Ensure minimum visible bar width for small values in benchmark graph#10
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #9
When Doublets benchmark values are too small relative to Neo4j values, the bars become invisible on the linear scale graph. This fix ensures non-zero values are rendered with at least 0.5% of the maximum value, guaranteeing approximately 2 pixels of visibility on the graph. Fixes #9 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This reverts commit 587c75c.
Member
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
Member
Author
🔄 Auto-restart 1/3Detected uncommitted changes from previous run. Starting new session to review and commit them. Uncommitted files: Auto-restart will stop after changes are committed or after 2 more iterations. Please wait until working session will end and give your feedback. |
Regenerated benchmark images using the fixed out.py script that ensures minimum visible bar width for small values. The Doublets bars are now visible on the linear scale graph. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 💰 Cost estimation:
Now working session is ended, feel free to review and add any feedback on the solution draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensure_min_visible()helper function that ensures non-zero values are rendered with at least 0.5% of the maximum valuebench1()to apply minimum visibility to all data series before plottingDocs/bench_rust.pngandDocs/bench_rust_log_scale.pngwith the fixed graphsProblem
When Doublets benchmark values are orders of magnitude smaller than Neo4j values (e.g., ~500ns vs ~50,000,000ns), the Doublets bars become completely invisible on the linear scale graph.
Solution
Calculate a minimum visible value based on the maximum value in the dataset and ensure all non-zero values are rendered at least at this minimum size. This preserves the visual indication that Doublets has a value for each operation while still showing the relative scale difference.
Test plan
bench_rust.pngshows visible bars for all Doublets valuesbench_rust_log_scale.png) is unaffectedFixes #9
🤖 Generated with Claude Code