-
Notifications
You must be signed in to change notification settings - Fork 35
csv testing and bug fixes #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @joshmoore - sorry this took so long to review; I'd like to take a look and get it resolved. Unfortunately, I don't have permission here to resolve the conflicts. (thank you for giving maintainers access to the PR - I am not sure why I can't resolve the conflicts with that permission but the button is unavailable to me). Can you resolve the conflicts here? Then I can walk through and get the tests passing. Thanks in advance! |
@sierra-moxon, no worries (though odd): done. |
It looks like this has gone stale while waiting to be reviewed |
Please let me know if there's something needed from my side. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
- Coverage 77.65% 77.52% -0.14%
==========================================
Files 52 52
Lines 4480 4493 +13
Branches 973 978 +5
==========================================
+ Hits 3479 3483 +4
- Misses 779 788 +9
Partials 222 222 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good to me.
This primarily adds the test cases mentioned under linkml/linkml#947. In debugging, there were a number of locations where an explicit
None
check helped with determining what was wrong which I've included. Please let me know if those should be separated out.Note: this is currently failing both for all attributes as well as all slots with: