Skip to content

Conversation

joshmoore
Copy link
Contributor

This primarily adds the test cases mentioned under linkml/linkml#947. In debugging, there were a number of locations where an explicit None check helped with determining what was wrong which I've included. Please let me know if those should be separated out.

Note: this is currently failing both for all attributes as well as all slots with:

>           self.objectB = Object(**as_dict(self.objectB))
E           TypeError: tests.test_loaders_dumpers.models.table.Object() argument after ** must be a mapping, not str

@sierra-moxon
Copy link
Member

Hi @joshmoore - sorry this took so long to review; I'd like to take a look and get it resolved. Unfortunately, I don't have permission here to resolve the conflicts. (thank you for giving maintainers access to the PR - I am not sure why I can't resolve the conflicts with that permission but the button is unavailable to me). Can you resolve the conflicts here? Then I can walk through and get the tests passing. Thanks in advance!

@joshmoore
Copy link
Contributor Author

@sierra-moxon, no worries (though odd): done.

@nlharris
Copy link
Contributor

It looks like this has gone stale while waiting to be reviewed

@joshmoore
Copy link
Contributor Author

Please let me know if there's something needed from my side.

Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.52%. Comparing base (ff268a3) to head (1f9636f).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
linkml_runtime/loaders/rdflib_loader.py 7.69% 10 Missing and 2 partials ⚠️
linkml_runtime/utils/yamlutils.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   77.65%   77.52%   -0.14%     
==========================================
  Files          52       52              
  Lines        4480     4493      +13     
  Branches      973      978       +5     
==========================================
+ Hits         3479     3483       +4     
- Misses        779      788       +9     
  Partials      222      222              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@amc-corey-cox amc-corey-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me.

@amc-corey-cox amc-corey-cox merged commit 9045b86 into linkml:main Oct 14, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants