Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at Dockerization #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

First pass at Dockerization #16

wants to merge 1 commit into from

Conversation

cmungall
Copy link
Member

No description provided.

@schristley
Copy link

These might be known issues but here is my experience.

The docker mostly worked for me. There is a typo in the CMD with "bash" at the end of the URL, with that fixed make docker-run let me generate the project files. I then used make docker-shell and ran make setup in my project directory. This failed at git commit because git author identity is unknown. Manually running git config to setup username and email worked, also could add -v ~/.gitconfig:/root/.gitconfig to the docker-run command.

I tried to do everything in the docker because I don't want to install poetry on my machine. This has the disadvantage that the poetry install is lost when exiting the container, but doing a make install worked. I suppose I should create a custom image for my project.

Separate issue but it was unclear how to update generated files like the JSON schema. The README has step 3: edit the schema yaml and step 4: run make test, but I guess there should be a step in between to run make site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants