mkdocs filter functionality #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
cmungall
approved these changes
Mar 13, 2024
sujaypatil96
approved these changes
Mar 13, 2024
sujaypatil96
requested changes
Mar 13, 2024
There was a problem hiding this comment.
My concern here is putting tablefilter.js in the root of the repo. Is that really the best place to put it? Also tablefilter.js needs to be copied under $(DOCDIR)/javascripts/ where $(DOCDIR) is the destination where all the markdown docs will be generated/outputted.
I wouldn't mind the creation of another folder under src/ called scripts/javascripts or something, and further customizing the gendoc Makefile target to also include these steps:
mkdir -p $(DOCDIR)/javascripts
$(RUN) cp $(SRC)/scripts/javascripts/* $(DOCDIR)/javascripts/
|
What are your thoughts on this @cmungall? |
|
@plbremer and @sujaypatil96 can we get an update on this PR? Do we still want to get this in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from #99
Adds filtration functionality to tables in mkdocs documentation.