-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add array class example #190
base: main
Are you sure you want to change the base?
Conversation
range: string | ||
latitude_in_deg: | ||
implements: | ||
- linkml:axis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary anymore given the above array_data_mapping
?
range: LatitudeSeries | ||
required: true | ||
annotations: | ||
axis_index: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary anymore given the above array_data_mapping
?
axis_index: 2 | ||
temperatures_in_K: | ||
implements: | ||
- linkml:array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename this in the metamodel? Is this scoped to linkml:DataArray
or unique across LinkML?
cc @sneakers-the-rat @cmungall I'm looking at how to 1) add attributes to arrays and 2) support labeling arrays with other arrays. For 1), I think we need to keep supporting classes that implement For 2) if we allow a |
ah yes, is it time for the second leg, the indexed array spec? Can we get a few examples of the desired datasets we want to support with this? I think it might be helpful to have a few concrete test cases here so we can get a handle on the constraints we'll need to handle. are the ones in |
This PR adds an alternate approach to specifying the
TemperatureDataset
defined intests/input/examples/schema_definition-native-array-1.yaml
. This approach uses classes that implementlinkml:NDArray
and have an attribute that implementslinkml:elements
as defined pre-1.7.0 release. This representation is necessary for adding additional attributes, e.g., user-specified units of measurement, conversion factor, precision/error, reference/zero point, or source, on the various arrays that make up aTemperatureDataset
. Seeking feedback on this approach.It also changes
y
->"y"
becausey
= True in YAML 1.1.