Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] VX-265 separate adding route via gw and interface #78

Merged
merged 5 commits into from
Aug 16, 2018

Conversation

John-Lin
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 15, 2018

Codecov Report

Merging #78 into master will increase coverage by 0.63%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   87.68%   88.31%   +0.63%     
==========================================
  Files           7        7              
  Lines         203      214      +11     
==========================================
+ Hits          178      189      +11     
  Misses         16       16              
  Partials        9        9
Impacted Files Coverage Δ
nl/link.go 76.19% <100%> (+5.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17522d4...33ff882. Read the comment docs.

@John-Lin John-Lin changed the title [Task] separate adding route via gw and interface [Task] VX-265 separate adding route via gw and interface Aug 16, 2018
nl/link.go Outdated
}

// AddRouteViaGateway is a function for Adding a route via gateway
// ex: ip route add 192.0.2.128/25 via 192.0.2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我們還是有傳入 dev 參數近來,所以覺得註解怪怪的

@John-Lin John-Lin merged commit c8b007b into master Aug 16, 2018
@John-Lin John-Lin deleted the johnlin/addroute-via branch August 16, 2018 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants